Omer Frenkel has posted comments on this change. Change subject: core: simplify CommonVmPoolWithVmsCommand#executeCommand ......................................................................
Patch Set 5: (1 comment) did you verify adding vms to existing pool works ok? http://gerrit.ovirt.org/#/c/26363/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java: Line 96: diskInfoDestinationMap = new HashMap<>(); Line 97: } Line 98: setVdsGroupId(parameters.getVmPool().getVdsGroupId()); Line 99: Line 100: nameForVmInPoolGenerator = new NameForVmInPoolGenerator(getParameters().getVmPool().getName()); did you verify everyone (rest, both portals) setting this parameter? Line 101: } Line 102: Line 103: protected void initTemplate() { Line 104: if (getVmTemplate() != null) { -- To view, visit http://gerrit.ovirt.org/26363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10b7bd20780f734cbe7c9b7c102b2e5442a722ac Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
