Michael Kublin has posted comments on this change.
Change subject: core: Use the hostSpmId during reconstructMaster
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
Line 136: select
fn_db_add_config_value('DisconnectPoolOnReconstruct','0,2','general');
It is mean that option is correct for all vdsm versions.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
Line 38: protected storage_domains _newMaster;
change back to private, use getNewMaster() method
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 113:
These is a bug, disconnectStorageFormats it is String,
_newMaster.getStorageFormat() it is ENUM : StorageFormatType.
Use _newMaster.getStorageFormat().value().
Also we don't need to send a disconnect for old vdsms at any case?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconstructMasterVDSCommandParameters.java
Line 92: getPrintableDomainsList());
Update toString also , add vdsSpmId
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ReconstructMasterVDSCommand.java
Line 25:
so, old vdsm can get an XML RPC call with additional parameter with out any
problem?
--
To view, visit http://gerrit.ovirt.org/4967
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8c4fceeda898e020a4153ccd36aa078eb200ac3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
