Doron Fediuck has submitted this change and it was merged.
Change subject: webadmin: Replace inner variable references in failure messages
......................................................................
webadmin: Replace inner variable references in failure messages
Currently the message processing code ignores variables that were
added by expanding other variables. This is not consistent with
the handling in AuditLog.
This patch fixes that and makes the behaviour the same. The only
risk here is that we have an expansion cycle, but that is
under our control and should not happen.
As an usage example think about the expansion of the following
messages:
"$filterType internal"
"$hostName dev-03"
"$filterName Network"
"$networkNames test"
"$detailMessage network(s) ${networkNames} are missing"
"The host ${hostName} did not satisfy ${filterType} filter
${filterName} because ${detailMessage}."
This is related to the our improvement of how we report scheduling
failures.
Change-Id: If70582ae35b8f94b4101dfc33865cc7976fd625c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077627
Signed-off-by: Martin Sivak <[email protected]>
---
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java
1 file changed, 10 insertions(+), 6 deletions(-)
Approvals:
Martin Sivák: Verified
Doron Fediuck: Looks good to me, approved
Kobi Ianko: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If70582ae35b8f94b4101dfc33865cc7976fd625c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
