Arik Hadas has posted comments on this change. Change subject: engine : Introduction of DecoratedCommand ......................................................................
Patch Set 10: (1 comment) partial review http://gerrit.ovirt.org/#/c/26336/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/DecoratedCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/DecoratedCommand.java: Line 20: @Override Line 21: public T getParameters() { Line 22: return innerCommand.getParameters(); Line 23: } Line 24: } what's the point of this interface if we call the endAction + getParameters methods of the inner command anyway? -- To view, visit http://gerrit.ovirt.org/26336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffe9899c324110502319078cf5fe16f3a4b8c11 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
