Ravi Nori has posted comments on this change.

Change subject: engine : Introduction of CallBack interface
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/26333/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java:

Line 22: import org.ovirt.engine.core.utils.log.Log;
Line 23: import org.ovirt.engine.core.utils.log.LogFactory;
Line 24: 
Line 25: public class SPMAsyncTask {
Line 26:     CommandCoordinator coco;
> Will change
Needs to be protected as CommandAsyncTask extends SPMAsyncTask and uses it
Line 27:     public SPMAsyncTask(CommandCoordinator coco, AsyncTaskParameters 
parameters) {
Line 28:         this.coco = coco;
Line 29:         setParameters(parameters);
Line 30:         setState(AsyncTaskState.Initializing);


-- 
To view, visit http://gerrit.ovirt.org/26333
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c12315c96168fd32dc05ac6de336ccdd63c9fbc
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to