Omer Frenkel has posted comments on this change. Change subject: core: monitoring - make host monitoring fetch mem commited from vms monitoring ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27921/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 197: return vdsReturnValue.getSucceeded(); Line 198: } Line 199: Line 200: private void refreshCommitedMemory() { Line 201: memCommited = vds.getGuestOverhead(); are you sure this cant be null? Line 202: vmsCoresCount = 0; Line 203: Line 204: for (VmInternalData runningVm : runningVms.values()) { Line 205: VmDynamic vmDynamic = runningVm.getVmDynamic(); -- To view, visit http://gerrit.ovirt.org/27921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a9f1aa04f979a1278614f7c96b33458da399997 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
