Greg Sheremeta has posted comments on this change. Change subject: webadmin: auto select dialog tab ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/27781/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java: Line 38: Line 39: /** Line 40: * Set of invalid tabs, empty if the model doesn't support tabs. Line 41: */ Line 42: private final Set<TabName> invalidTabs = new HashSet<TabName>(); Alex and Vojtech, did you discuss whether Model should be aware of Tabs? To me, adding such UI awareness to a model feels like too much for a model to know. But I'm not very familiar with this patch. Line 43: Line 44: private final List<HandlerRegistration> handlerRegistrations = new ArrayList<HandlerRegistration>(); Line 45: Line 46: public static final String CANCEL_COMMAND = "Cancel"; //$NON-NLS-1$ http://gerrit.ovirt.org/#/c/27781/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TabName.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TabName.java: Line 1: package org.ovirt.engine.ui.uicommonweb.models; Line 2: Line 3: /** Line 4: * Enumeration of all available tab names. is this across every dialog? Line 5: */ Line 6: public enum TabName { Line 7: GENERAL_TAB, Line 8: CONSOLE_TAB, -- To view, visit http://gerrit.ovirt.org/27781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9c5ad0cd3ee7f54606958b1fc8abd2bbd972ed Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
