Vojtech Szocs has posted comments on this change. Change subject: userportal: extended event sub tab loading ......................................................................
Patch Set 1: (2 comments) Please see my comments in DataBoundTabModelProvider.java - otherwise, good patch. http://gerrit.ovirt.org/#/c/28035/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java: Line 63: }); Line 64: getModel().getPropertyChangedEvent().addListener(new IEventListener() { Line 65: @Override Line 66: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 67: if (args instanceof PropertyChangedEventArgs) { For PropertyChangedEvent, "args" will always be an instance of PropertyChangedEventArgs. Therefore you can also cast "args" directly, for example: String propName = ((PropertyChangedEventArgs) args).propertyName; Above should simplify the code a bit. It's up to your consideration, as for me the instanceof is just unnecessary complexity. BTW, we have a BZ exactly for this issue: https://bugzilla.redhat.com/show_bug.cgi?id=1034844 Line 68: PropertyChangedEventArgs pcArgs = (PropertyChangedEventArgs) args; Line 69: if (PropertyChangedEventArgs.Args.PROGRESS.toString().equals(pcArgs.propertyName)) { Line 70: clearData(); Line 71: } Line 65: @Override Line 66: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 67: if (args instanceof PropertyChangedEventArgs) { Line 68: PropertyChangedEventArgs pcArgs = (PropertyChangedEventArgs) args; Line 69: if (PropertyChangedEventArgs.Args.PROGRESS.toString().equals(pcArgs.propertyName)) { I'm really wondering why is PropertyChangedEventArgs.Args.PROGRESS an enum member, instead of being String constant like this: public class PropertyChangedEventArgs extends EventArgs { public static final String PROGRESS = "Progress"; ... } All current code referencing PropertyChangedEventArgs.Args is just invoking toString method on PROGRESS. Can we just make PROGRESS a String constant? (What's the advantage of enum here?) Line 70: clearData(); Line 71: } Line 72: } Line 73: } -- To view, visit http://gerrit.ovirt.org/28035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81495d93c0fb9a7989ff2147d6bfcbd8d769d6ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
