Yair Zaslavsky has posted comments on this change. Change subject: engine : Introduction of CommandExecutor and AsyncCommandCallBack ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28154/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 18: import javax.naming.InitialContext; Line 19: import javax.naming.NamingException; Line 20: import java.util.concurrent.ScheduledThreadPoolExecutor; Line 21: Line 22: class CommandExecutor { why not public class? Line 23: Line 24: private static final ScheduledThreadPoolExecutor executor = new ScheduledThreadPoolExecutor(Config.<Integer> getValue(ConfigValues.CommandCoordinatorThreadPoolSize)); Line 25: private static final String BACKEND_COMMAND_OBJECTS_HANDLER_JNDI_NAME = Line 26: "java:global/engine/bll/Backend!org.ovirt.engine.core.bll.interfaces.BackendCommandObjectsHandler"; http://gerrit.ovirt.org/#/c/28154/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java: Line 2: Line 3: import org.ovirt.engine.core.common.action.VdcReturnValueBase; Line 4: Line 5: public interface CommandCallBack { Line 6: public abstract void setExecutionResult(VdcReturnValueBase result); > why abstract? i agree, in general please have onXXX methods or something like Arik suggested when it comes to callbacks, if possible. -- To view, visit http://gerrit.ovirt.org/28154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70922b5b836971eca76dee26ba67b7023d546fe6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
