Maor Lipchuk has posted comments on this change.
Change subject: core: expose the V3 domain format in dc 3.1
......................................................................
Patch Set 12: Looks good to me, but someone else must approve
(2 inline comments)
It looks good, please see inline comments/suggestions
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
Line 149: private boolean correctStorageDomainFormat() {
Please consider adding a test for this method.
....................................................
Commit Message
Line 8:
Please elaborate more in the commit message. (Maybe also add the ovirt wiki
page)
--
To view, visit http://gerrit.ovirt.org/4476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibafcb53007eb6e531f024cd054ff2673a7d431e1
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
