Sandro Bonazzola has posted comments on this change. Change subject: Avoiding legacy health servlet usage ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26878/4/src/ovirt_hosted_engine_setup/check_liveliness.py File src/ovirt_hosted_engine_setup/check_liveliness.py: Line 103: ), Line 104: username='admin@internal', Line 105: password=self.environment[ Line 106: ohostedcons.EngineEnv.ADMIN_PASSWORD, Line 107: ], > I've to check if I'm able to discriminate a wrong password response from an I agree, we don't need anything more than that. Line 108: # it's simply a ping, we are basically Line 109: # trusting any certs Line 110: ca_file=self._cacert, Line 111: ) -- To view, visit http://gerrit.ovirt.org/26878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3522ccb82eee4bf7f04ded012d9badc97c55b5a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
