Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: ensure restarted services survive reboot ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28235/1/packaging/setup/plugins/ovirt-engine-common/base/system/hostile_services.py File packaging/setup/plugins/ovirt-engine-common/base/system/hostile_services.py: Line 99: # See https://bugzilla.redhat.com/1083551 Line 100: self.services.startup( Line 101: name=service, Line 102: state=True Line 103: ) > at cleanup I do not want to modify system state. I think the whole thing has to be reviewed better. Looks like dwhd is handled by dwh setup so it shouldn't be handled here. Ok for not modifying system state at cleanup. is it better closeup or misc in this case? Line 104: Line 105: -- To view, visit http://gerrit.ovirt.org/28235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2333590beb9f4cabcc7eb68cbbacac85b453318d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
