Sandro Bonazzola has posted comments on this change.

Change subject: use VDSM for creating volumes
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/28237/5/ovirt_hosted_engine_ha/lib/storage_backends.py
File ovirt_hosted_engine_ha/lib/storage_backends.py:

Line 167: 
Line 168:         # Connect to local VDSM
Line 169:         logger.debug("Connecting to VDSM")
Line 170:         connection = vdsm.vdscli.connect(
Line 171:             
hostPort=vdsm.vdscli.cannonizeHostPort(hostPort="localhost")
> connect() without params should do the Right Thing.
I'll try without passing any argument, thanks for the hint.
Line 172:         )
Line 173: 
Line 174:         # Check of the volume already exists
Line 175:         response = connection.getVolumePath(


-- 
To view, visit http://gerrit.ovirt.org/28237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeae8bfbe931aa47b7afa36207f712f1335c2bd7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to