Vojtech Szocs has posted comments on this change. Change subject: webadmin: sorting DC tabs ......................................................................
Patch Set 1: > @Vojtech I made this work without replacing the SortedSet by guaranteeing > that each comparator falls back to an entity comparator if the specified > comparator returns 'equals'. One other way would be to override the sortItems > in SearchableListModel and sort with a list in there. Then anything that is > or extends the SortedListModel will still use the SortedSet, but anything > that extends the SearchableListModel will use the list, what do you think? Let's try to keep the SortedSet behavior of item collection for now, I'll update new patchset to illustrate how we could do this, feel free to modify. -- To view, visit http://gerrit.ovirt.org/28225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95272bd4594a66611c11aaa690d44d88b082b49 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
