Alon Bar-Lev has posted comments on this change. Change subject: Split of engine-setup-plugin ......................................................................
Patch Set 28: (2 comments) http://gerrit.ovirt.org/#/c/27647/28/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 919: %{engine_data}/setup/bin/ovirt-engine-remove Line 920: %{engine_data}/setup/bin/ovirt-engine-rename Line 921: %{engine_data}/setup/bin/ovirt-engine-setup Line 922: %{engine_data}/setup/bin/ovirt-engine-setup.env Line 923: %{engine_data}/setup/ovirt_engine_setup/*.py* I just play with the thought of putting the base within own folder, this way the ovirt_engine_setup will be empty... it will simplify future, but makes it harder to be backward compatible during the transition. Line 924: %{engine_data}/setup/plugins/*/base/ Line 925: %{engine_state}/backups/ Line 926: %{engine_state}/setup/ Line 927: Line 950: %files setup-plugin-ovirt-engine-common Line 951: Line 952: %dir %{engine_data}/setup/ovirt_engine_setup/engine_common/ Line 953: %{engine_data}/setup/dbutils/ Line 954: %{engine_data}/setup/ovirt_engine_setup/engine_common/*.py* oh... sorry I missed this... please remove: %dir %{engine_data}/setup/ovirt_engine_setup/engine_common/ leave only: %{engine_data}/setup/ovirt_engine_setup/engine_common/ same for all other. you do not need to select individual files... so just own the entire directory with its files. Line 955: %{engine_data}/setup/plugins/*/ovirt-engine-common/ Line 956: Line 957: %files setup-plugin-websocket-proxy Line 958: -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
