Arik Hadas has posted comments on this change. Change subject: core: process VMs that went down on separate thread ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/28220/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java: Line 108: Line 109: @Override Line 110: public void processOnVmStop(Collection<Guid> vmIds) { Line 111: for (final Guid vmId : vmIds) { Line 112: log.infoFormat("process VM {0} that went down", vmId); > do we really need this log? now that it is a command we should have a log f Done Line 113: ThreadPoolUtil.execute(new Runnable() { Line 114: @Override Line 115: public void run() { Line 116: Backend.getInstance().runInternalAction(VdcActionType.ProcessDownVm, -- To view, visit http://gerrit.ovirt.org/28220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I903992087c7d5975548746f45451fccbfd38b299 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
