Arik Hadas has posted comments on this change. Change subject: core: refactor ProcessDownVmCommand ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/28146/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java: Line 88: /** Line 89: * Update vm configuration with NEXT_RUN configuration, if exists Line 90: * @param vmId Line 91: */ Line 92: private void applyNextRunConfiguration(Guid vmId) { > if we would set vmId in the ctor, we wouldnt need vmId as parameter to the Done Line 93: // Remove snpashot first, in case other update is in progress, it will block this one with exclusive lock Line 94: // and any newer update should be preffered to this one. Line 95: Snapshot runSnap = getSnapshotDAO().get(vmId, SnapshotType.NEXT_RUN); Line 96: if (runSnap != null) { Line 108: } Line 109: } Line 110: } Line 111: Line 112: private VmManagementParametersBase createUpdateVmParameters(VM vm) { > if we would set vmId in the ctor, we wouldnt need vm as parameter to the me Done Line 113: // clear non updateable fields got from config Line 114: vm.setExportDate(null); Line 115: vm.setOvfVersion(null); Line 116: -- To view, visit http://gerrit.ovirt.org/28146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0325e208aa9a76ad859ffff502d02e89f0001caa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
