Kobi Ianko has posted comments on this change. Change subject: engine: NUMA feature transaction support ......................................................................
Patch Set 1: (7 comments) http://gerrit.ovirt.org/#/c/28241/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 892: } Line 893: } Line 894: Line 895: protected void addVmNumaNodes() { Line 896: List<VdsNumaNode> numaNodes = new ArrayList<VdsNumaNode>(); java 7 diamond style generics could be nice Line 897: for (VmNumaNode vnode : getParameters().getVmStaticData().getvNumaNodeList()) { Line 898: numaNodes.add(vnode); Line 899: } Line 900: DbFacade.getInstance().getVmNumaNodeDAO().massSaveNumaNode(numaNodes, null, getVmId()); Line 893: } Line 894: Line 895: protected void addVmNumaNodes() { Line 896: List<VdsNumaNode> numaNodes = new ArrayList<VdsNumaNode>(); Line 897: for (VmNumaNode vnode : getParameters().getVmStaticData().getvNumaNodeList()) { Is there a reason for coping from one list to another list? Line 898: numaNodes.add(vnode); Line 899: } Line 900: DbFacade.getInstance().getVmNumaNodeDAO().massSaveNumaNode(numaNodes, null, getVmId()); Line 901: } http://gerrit.ovirt.org/#/c/28241/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 569: } Line 570: } Line 571: Line 572: protected void addVmNumaNodes() { Line 573: List<VdsNumaNode> numaNodes = new ArrayList<VdsNumaNode>(); diamond style Line 574: for (VmNumaNode vnode : DbFacade.getInstance().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(getVmId())) { Line 575: for (Pair<Guid, Pair<Boolean, Integer>> pair : vnode.getVdsNumaNodeList()) { Line 576: pair.setFirst(null); Line 577: pair.getSecond().setFirst(false); Line 570: } Line 571: Line 572: protected void addVmNumaNodes() { Line 573: List<VdsNumaNode> numaNodes = new ArrayList<VdsNumaNode>(); Line 574: for (VmNumaNode vnode : DbFacade.getInstance().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(getVmId())) { could getAllVmNumaNodeByVmId be null? if so we need to null check it Line 575: for (Pair<Guid, Pair<Boolean, Integer>> pair : vnode.getVdsNumaNodeList()) { Line 576: pair.setFirst(null); Line 577: pair.getSecond().setFirst(false); Line 578: } Line 571: Line 572: protected void addVmNumaNodes() { Line 573: List<VdsNumaNode> numaNodes = new ArrayList<VdsNumaNode>(); Line 574: for (VmNumaNode vnode : DbFacade.getInstance().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(getVmId())) { Line 575: for (Pair<Guid, Pair<Boolean, Integer>> pair : vnode.getVdsNumaNodeList()) { same for getVdsNumaNodeList Line 576: pair.setFirst(null); Line 577: pair.getSecond().setFirst(false); Line 578: } Line 579: numaNodes.add(vnode); Line 575: for (Pair<Guid, Pair<Boolean, Integer>> pair : vnode.getVdsNumaNodeList()) { Line 576: pair.setFirst(null); Line 577: pair.getSecond().setFirst(false); Line 578: } Line 579: numaNodes.add(vnode); do we need to create a new list, can't we update the existing one? Line 580: } Line 581: DbFacade.getInstance().getVmNumaNodeDAO().massSaveNumaNode(numaNodes, null, getVmTemplateId()); Line 582: } Line 583: http://gerrit.ovirt.org/#/c/28241/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 338: } Line 339: } Line 340: Line 341: private void UpdateVmNumaNodes() { Line 342: VmNumaNodeDAO dao = DbFacade.getInstance().getVmNumaNodeDAO(); you can work with list.retainAll and list.removeAll, this could make a shorter more elegant code Line 343: List<VdsNumaNode> addList = new ArrayList<VdsNumaNode>(); Line 344: List<VdsNumaNode> updateList = new ArrayList<VdsNumaNode>(); Line 345: List<Guid> removeList = new ArrayList<Guid>(); Line 346: List<VmNumaNode> oldList = dao.getAllVmNumaNodeByVmId(getVmId()); -- To view, visit http://gerrit.ovirt.org/28241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84e59fa38c9174fe7150116bf3c8832f7fac1dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
