Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: refactor db credentials questions ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28261/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/db/connection.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/db/connection.py: Line 111 Line 112 Line 113 Line 114 Line 115 I pass them here already http://gerrit.ovirt.org/#/c/28261/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py: Line 42: self._renamedDBResources = False Line 43: self._provisioning = postgres.Provisioning( Line 44: plugin=self, Line 45: dbenvkeys=osetupcons.Const.ENGINE_DB_ENV_KEYS, Line 46: defaults=osetupcons.Const.DEFAULT_ENGINE_DB_ENV_KEYS, > we probably need to drop these defaults in favour of explicit. Not sure why, but I do not really mind. Added it for the questions, changed here too just because I could (and to make code shorter with less duplication). Line 47: ) Line 48: Line 49: @plugin.event( Line 50: stage=plugin.Stages.STAGE_INIT, -- To view, visit http://gerrit.ovirt.org/28261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1451e581a89b750ab34c09e34faeb77403909f00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
