Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing usage of Acct ......................................................................
Patch Set 11: (4 comments) http://gerrit.ovirt.org/#/c/27070/11/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java: Line 22: import org.ovirt.engine.api.extensions.Base; Line 23: import org.ovirt.engine.api.extensions.ExtMap; Line 24: import org.ovirt.engine.api.extensions.aaa.Acct; Line 25: import org.ovirt.engine.api.extensions.aaa.Authn; Line 26: import org.ovirt.engine.core.aaa.AcctUtils; > not sure these are needed Done Line 27: import org.ovirt.engine.core.aaa.AuthenticationProfile; Line 28: import org.ovirt.engine.core.aaa.AuthenticationProfileRepository; Line 29: Line 30: /** http://gerrit.ovirt.org/#/c/27070/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 170: Line 171: // Check that the authenticator provided by the profile supports password authentication: Line 172: authnExtension = profile.getAuthn(); Line 173: authRecord = (ExtMap) getParameters().getAuthRecord(); Line 174: int reportReason = Acct.ReportReason.PRINCIPAL_LOGIN_NEGOTIATE; > excluded basic authentication... ok. Line 175: String loginName = null; Line 176: if (authRecord == null) { Line 177: reportReason = Acct.ReportReason.PRINCIPAL_LOGIN_CREDENTIALS; Line 178: Line 237: AcctUtils.reportRecords(Acct.ReportReason.PRINCIPAL_RECORD_NOT_FOUND, null, principalRecord, loginName); Line 238: Line 239: return false; Line 240: } Line 241: > - Done Line 242: AcctUtils.reportRecords(reportReason, authRecord, principalRecord, loginName); Line 243: DirectoryUser directoryUser = AuthzUtils.mapPrincipalRecord(profile.getAuthz(), principalRecord); Line 244: Line 245: http://gerrit.ovirt.org/#/c/27070/11/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Acct.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Acct.java: Line 109: * Will have {@link PrincipalRecord}. Line 110: */ Line 111: public static final int PRINCIPAL_CREDENTIALS_CHANGED = 10; Line 112: /** Line 113: * Principal record was not found. > as you do not have principal record,I would put this before these constants Ok, so I'll change this to PRINCIPAL_RECORD_INVALID (and change the order). Line 114: */ Line 115: public static final int PRINCIPAL_RECORD_NOT_FOUND = 11; Line 116: /** Line 117: * Access denied. -- To view, visit http://gerrit.ovirt.org/27070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief13d233d11b7ab32b328735b4f58ec7cffff567 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
