Barak Azulay has posted comments on this change. Change subject: core: Add kdump detection into fencing flow ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28072/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java: Line 74: kdumpDetected = kdumpStatus != null; Line 75: if (!kdumpDetected) { Line 76: ThreadUtils.sleep(messageInterval); Line 77: } Line 78: listenerAlive = isListenerAlive(); I'm not sure 2 steps are required: detectHostStartedKdumping & detectHostFinishedKdumping Line 79: } Line 80: } Line 81: Line 82: private void detectHostFinishedKdumping() { -- To view, visit http://gerrit.ovirt.org/28072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18145bc5814dc0b97b8ed6593f0c76473285ae16 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
