Martin Sivák has posted comments on this change. Change subject: set the storage backend according to the config file ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28271/3/ovirt_hosted_engine_ha/agent/hosted_engine.py File ovirt_hosted_engine_ha/agent/hosted_engine.py: Line 415: for attempt in range(0, constants.WAIT_FOR_STORAGE_RETRY): Line 416: try: Line 417: self._broker.set_storage_domain(storage_backend_type, Line 418: sd_uuid=sd_uuid, Line 419: dom_type=dom_type) You have to pass the volume and image uuids to the backend as well iirc. Line 420: break Line 421: except Exception as _ex: Line 422: self._log.info("Failed set the storage domain: '{0}'." Line 423: " Waiting '{1}'s before the next attempt". http://gerrit.ovirt.org/#/c/28271/3/ovirt_hosted_engine_ha/client/client.py File ovirt_hosted_engine_ha/client/client.py: Line 113: Line 114: sb = storage_broker.StorageBroker() Line 115: sb.set_storage_domain("client", StorageBackendTypes.FilesystemBackend, Line 116: sd_uuid=sd_uuid, dom_type=dom_type) Line 117: stats = sb.get_raw_stats_for_service_type("client", service_type) This should use the configuration file and backend detection as well. (But it will probably work because we still create the symlinks for compatibility reasons) Line 118: Line 119: return self._parse_stats(stats, mode) Line 120: Line 121: def _parse_stats(self, stats, mode): -- To view, visit http://gerrit.ovirt.org/28271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cf19510ae52157e21e08215bc88953f1c1f937c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
