Arik Hadas has posted comments on this change. Change subject: core: fix conflicting getter definitions ......................................................................
Patch Set 2: martin, thanks for noting that. anyway, when I call "isX", I expect to receive true/false. it's confusing when Boolean is returned as then I need to handle the null case. so I think that even without considering the REST tests, we should stick to the Java's convention and use the 'get' way. -- To view, visit http://gerrit.ovirt.org/28263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37b5e286c21814e757e6369ef9b2a642ac0c621d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
