Yair Zaslavsky has posted comments on this change. Change subject: engine : Add quartz to handle AsycCommands ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/28160/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 41: new Object[]{}, Config.<Integer>getValue(ConfigValues.AsyncCommandPollingRateInSeconds), Line 42: Config.<Integer>getValue(ConfigValues.AsyncCommandPollingRateInSeconds), TimeUnit.SECONDS); Line 43: } Line 44: Line 45: @OnTimerMethodAnnotation("timer_Elapsed") please fix the value of the annotation , the "pattern" we have is that it equals to the method name. Line 46: public synchronized void invokeCallbackMethods() { Line 47: for (Guid cmdId : cmdCallBackMap.keySet()) { Line 48: CommandCallBack callBack = cmdCallBackMap.get(cmdId); Line 49: CommandStatus status = coco.getCommandStatus(cmdId); http://gerrit.ovirt.org/#/c/28160/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BackendUtils.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BackendUtils.java: Line 13: * This method should be used only at {@link BackendUtils} code for creating Line 14: * and execution {@link BackendUtils} objects directly. Line 15: * @return proxy object to create the {@link BackendUtils} objects and run them Line 16: */ Line 17: public static BackendCommandObjectsHandler getBackendCommandObjectsHandler(Log log) { I have some discussion with vojtech around such a lookup in another review - bare in mind nobody here closes the context. IMHO this is not a good practice. Line 18: try { Line 19: InitialContext ctx = new InitialContext(); Line 20: return (BackendCommandObjectsHandler) ctx.lookup(BACKEND_COMMAND_OBJECTS_HANDLER_JNDI_NAME); Line 21: } catch (NamingException e) { -- To view, visit http://gerrit.ovirt.org/28160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b1e5945884aec412ba412e39266129004d7218 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
