Juan Hernandez has posted comments on this change. Change subject: restapi: API support to query gluster volume profile info ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/28010/3/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 4049: </xs:extension> Line 4050: </xs:complexContent> Line 4051: </xs:complexType> Line 4052: Line 4053: <xs:element name="volume_profileDetails" type="GlusterVolumeProfileDetails"/> Element names should use underscores to separate words, not camel case, for example volume_profile_details. Please do the same for all the other element names. Line 4054: <xs:complexType name="GlusterVolumeProfileDetails"> Line 4055: <xs:annotation> Line 4056: <xs:appinfo> Line 4057: <jaxb:class name="GlusterVolumeProfileDetails"/> Line 4075: </xs:complexType> Line 4076: Line 4077: <xs:element name="brick_profileDetail" type="BrickProfileDetail"/> Line 4078: <xs:complexType name="BrickProfileDetail"> Line 4079: <xs:complexContent> Indent this correctly: 2 spaces per level. Line 4080: <xs:extension base="EntityProfileDetail"> Line 4081: <xs:sequence> Line 4082: <xs:element ref="brick" minOccurs="0" maxOccurs="1"/> Line 4083: </xs:sequence> Line 4099: </xs:sequence> Line 4100: </xs:complexType> Line 4101: Line 4102: <xs:element name="nfs_profileDetail" type="NfsProfileDetail"/> Line 4103: <xs:complexType name="NfsProfileDetail"> Indent this correctly. Line 4104: <xs:complexContent> Line 4105: <xs:extension base="EntityProfileDetail"> Line 4106: <xs:sequence> Line 4107: <xs:element name="nfsServerIp" type="xs:string" minOccurs="0" maxOccurs="1"/> -- To view, visit http://gerrit.ovirt.org/28010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff04cc30f01a7fbe9d6e48b8498d405d05c41c25 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
