Fabian Deutsch has posted comments on this change. Change subject: engine_page: remove dep. from ovirt_config_setup.engine ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28232/3/src/engine_page.py File src/engine_page.py: Line 56: Returns: True or False Line 57: """ Line 58: Line 59: if not os.path.exists(conf_file): Line 60: return False You should probably raise an exception here as well. Line 61: Line 62: try: Line 63: cfg = ConfigParser.RawConfigParser() Line 64: cfg.read(conf_file) -- To view, visit http://gerrit.ovirt.org/28232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia04f6fb1d3822828f543cfa4472d9e224162b5ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
