Kanagaraj M has posted comments on this change. Change subject: webadmin : Gluster Volume Profile ......................................................................
Patch Set 29: (2 comments) http://gerrit.ovirt.org/#/c/27470/29/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java: Line 166: } Line 167: Line 168: final VolumeProfileStatisticsModel profileStatsModel = this; Line 169: Line 170: profileStatsModel.startProgress(ConstantsManager.getInstance().getConstants().fetchingDataMessage()); you could just say startProgress Line 171: Line 172: AsyncDataProvider.getGlusterVolumeProfilingStatistics(new AsyncQuery(new INewAsyncCallback() { Line 173: @Override Line 174: public void onSuccess(Object model, Object returnValue) { Line 171: Line 172: AsyncDataProvider.getGlusterVolumeProfilingStatistics(new AsyncQuery(new INewAsyncCallback() { Line 173: @Override Line 174: public void onSuccess(Object model, Object returnValue) { Line 175: profileStatsModel.stopProgress(); same here Line 176: VdcQueryReturnValue vdcValue = (VdcQueryReturnValue) returnValue; Line 177: GlusterVolumeProfileInfo profileInfoEntity =vdcValue.getReturnValue(); Line 178: setProfileInfo(profileInfoEntity); Line 179: if((profileInfoEntity == null) || (!vdcValue.getSucceeded())) { -- To view, visit http://gerrit.ovirt.org/27470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic305a0fece18f29d24a9d0324391e484681fa033 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
