Allon Mureinik has posted comments on this change. Change subject: core: Added template & pool cleanups to force remove SD (#818091) ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/dbscripts/storages_sp.sql Line 521: CREATE GLOBAL TEMPORARY TABLE tt_TEMPTEMPLATESTABLE AS select vm_guid The table is needed since after deleting from image_storage_domain_map the query on images_storage_domain_view will show 0 lines, and it is used later on - e.g., when deleting from permissions. Line 540: delete FROM snapshots where vm_id in (select vm_guid FROM vm_static where vmt_guid in (select vm_guid from tt_TEMPTEMPLATESTABLE)); mkublin - both deletes are requried - one is for vms and one for templates. tnisan - mkublin has a point, this should be done in a single statement (with a OR condition, unfortunately). -- To view, visit http://gerrit.ovirt.org/5407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b4035a593dc208fa485c5c5ea970c949cb1d6f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
