Allon Mureinik has posted comments on this change. Change subject: core: Testing MaxBlockDiskSize validation ......................................................................
Patch Set 1: (3 inline comments) basically looks good - one question pending answer and two little style issues. .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java Line 51: public static MockConfigRule mcr = new MockConfigRule( question: in what units is MaxBlockDiskSize defined? Line 241: @Test Please put the annotation on top of the method, not the javadoc. Line 258: @Test same here. -- To view, visit http://gerrit.ovirt.org/5406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e6b068f6a4ebb58859162c1cd89c53f7775aa68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
