Alon Bar-Lev has posted comments on this change. Change subject: Introduction of filters to unify AAA flows for UI and REST-API ......................................................................
Patch Set 48: (2 comments) http://gerrit.ovirt.org/#/c/28022/48/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/LoginFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/LoginFilter.java: Line 62: } Line 63: } Line 64: doFilter = true; Line 65: } catch (Exception ex) { Line 66: log.error("Error in login to engine ", ex); don't we want stack trace only in debug? Line 67: ((HttpServletResponse) response).sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR); Line 68: } Line 69: if (doFilter) { Line 70: chain.doFilter(request, response); http://gerrit.ovirt.org/#/c/28022/48/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java: Line 54: } catch (NumberFormatException ex) { Line 55: log.error("Session-TTL header was not passed. Not setting TTL value"); Line 56: } Line 57: } Line 58: chain.doFilter(request, response); this should be outside of the try/catch scope Line 59: if (!persistentAuth && FiltersHelper.isAuthenticated(req)) { Line 60: InitialContext ctx = new InitialContext(); Line 61: try { Line 62: FiltersHelper.getBackend(ctx).runAction( -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 48 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
