Simone Tiraboschi has posted comments on this change. Change subject: Split of engine-setup-plugin ......................................................................
Patch Set 36: (8 comments) http://gerrit.ovirt.org/#/c/27647/36/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 947: %ghost %config(noreplace) %{_sysconfdir}/firewalld/services/ovirt.xml Line 948: Line 949: %files setup-plugin-ovirt-engine-common Line 950: Line 951: %{engine_data}/setup/dbutils/ > in 3.5 we can remove these, as upgrade from 3.4 will not have an issue. so let's keep it here till we are sure that we don't need anymore changedbowner.sh; when we are sure about it I'll remove OVIRT_ENGINE_DB_CHANGE_OWNER constant and I'll move the dbutils folder to the engine package in another patch. Line 952: %{engine_data}/setup/ovirt_engine_setup/engine_common/ Line 953: %{engine_data}/setup/plugins/*/ovirt-engine-common/ Line 954: Line 955: %files setup-plugin-websocket-proxy http://gerrit.ovirt.org/#/c/27647/36/packaging/setup/ovirt_engine_setup/engine_common/enginecommonconstants.py File packaging/setup/ovirt_engine_setup/engine_common/enginecommonconstants.py: Line 51: HTTPD_CONF_OVIRT_ENGINE = os.path.join( Line 52: DIR_HTTPD, Line 53: 'conf.d', Line 54: 'z-ovirt-engine-proxy.conf', Line 55: ) > this is ovirt-engine specific Done Line 56: HTTPD_CONF_OVIRT_ROOT = os.path.join( Line 57: DIR_HTTPD, Line 58: 'conf.d', Line 59: 'ovirt-engine-root-redirect.conf', Line 56: HTTPD_CONF_OVIRT_ROOT = os.path.join( Line 57: DIR_HTTPD, Line 58: 'conf.d', Line 59: 'ovirt-engine-root-redirect.conf', Line 60: ) > this is ovirt-engine specific Done Line 61: HTTPD_CONF_SSL = os.path.join( Line 62: DIR_HTTPD, Line 63: 'conf.d', Line 64: 'ssl.conf', Line 66: HTTPD_CONF_OVIRT_ENGINE_TEMPLATE = os.path.join( Line 67: osetupcons.FileLocations.OVIRT_SETUP_DATADIR, Line 68: 'conf', Line 69: 'ovirt-engine-proxy.conf.v2.in', Line 70: ) > this is ovirt-engine specific Done Line 71: HTTPD_CONF_OVIRT_ROOT_TEMPLATE = os.path.join( Line 72: osetupcons.FileLocations.OVIRT_SETUP_DATADIR, Line 73: 'conf', Line 74: 'ovirt-engine-root-redirect.conf.in', Line 71: HTTPD_CONF_OVIRT_ROOT_TEMPLATE = os.path.join( Line 72: osetupcons.FileLocations.OVIRT_SETUP_DATADIR, Line 73: 'conf', Line 74: 'ovirt-engine-root-redirect.conf.in', Line 75: ) > this is ovirt-engine specific Done Line 76: Line 77: OVIRT_ENGINE_DB_UTILS_DIR = os.path.join( Line 78: OVIRT_ENGINE_COMMON_DATADIR, Line 79: 'setup', Line 86: ) Line 87: OVIRT_ENGINE_TASKCLEANER = os.path.join( Line 88: OVIRT_ENGINE_DB_UTILS_DIR, Line 89: 'taskcleaner.sh' Line 90: ) > this is engine specific Done Line 91: OVIRT_ENGINE_DB_CHANGE_OWNER = os.path.join( Line 92: OVIRT_ENGINE_DB_UTILS_DIR, Line 93: 'changedbowner.sh' Line 94: ) Line 335: Line 336: HTTPD_SERVICE = 'OVESETUP_APACHE/httpdService' Line 337: Line 338: HTTPD_CONF_SSL = 'OVESETUP_APACHE/configFileSsl' Line 339: HTTPD_CONF_OVIRT_ENGINE = 'OVESETUP_APACHE/configFileOvirtEngine' > we need a config per engine and per reports Done Line 340: HTTPD_CONF_OVIRT_ROOT = 'OVESETUP_APACHE/configFileOvirtRoot' Line 341: Line 342: CONFIGURE_ROOT_REDIRECTIOND_DEFAULT = \ Line 343: 'OVESETUP_APACHE/configureRootRedirectionDefault' Line 347: @osetupattrs( Line 348: postinstallfile=True, Line 349: ) Line 350: def CONFIGURED(self): Line 351: return 'OVESETUP_APACHE/configured' > the configured is different between the engine and reports. Done Line 352: Line 353: @osetupattrs( Line 354: answerfile=True, Line 355: summary=True, -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 36 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
