anmolbabu has posted comments on this change. Change subject: engine : volume profile export to pdf command ......................................................................
Patch Set 8: (6 comments) http://gerrit.ovirt.org/#/c/28000/8/backend/manager/dependencies/pom.xml File backend/manager/dependencies/pom.xml: Line 463: <groupId>com.itextpdf</groupId> Line 464: <artifactId>itextpdf</artifactId> Line 465: <moduleName>com.itextpdf</moduleName> Line 466: </module> Line 467: > Please remove this white space. Done Line 468: </modules> Line 469: </configuration> Line 470: </plugin> Line 471: http://gerrit.ovirt.org/#/c/28000/8/backend/manager/modules/bll/pom.xml File backend/manager/modules/bll/pom.xml: Line 136: <dependency> Line 137: <groupId>org.apache.xmlrpc</groupId> Line 138: <artifactId>xmlrpc-client</artifactId> Line 139: </dependency> Line 140: > Please remove this white space Done Line 141: <!-- logging implementation used for unit tests --> Line 142: <dependency> Line 143: <groupId>org.slf4j</groupId> Line 144: <artifactId>slf4j-log4j12</artifactId> http://gerrit.ovirt.org/#/c/28000/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreatePdf.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreatePdf.java: Line 41: } Line 42: Line 43: public PdfPTable createTableWithRequiredColumns(String[] columnHeaders, int noOfHeaderRows) throws BadElementException { Line 44: PdfPTable table = new PdfPTable(columnHeaders.length); Line 45: for(int i = 0; i < columnHeaders.length; i++) { > Please format this according to our formatting rules. I see a whole bunch o Done Line 46: PdfPCell tableColumnCell = new PdfPCell(new Phrase(columnHeaders[i])); Line 47: tableColumnCell.setHorizontalAlignment(Element.ALIGN_CENTER); Line 48: table.addCell(tableColumnCell); Line 49: } http://gerrit.ovirt.org/#/c/28000/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeProfilePdfExportCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeProfilePdfExportCommand.java: Line 31: public class GlusterVolumeProfilePdfExportCommand extends GlusterCommandBase<GlusterVolumeCreatePdfParameters> { Line 32: Line 33: CreatePdf createPdf; Line 34: Line 35: String[] profileColumnHeaders = { "File operation", "No. of Invocations", "Max-Latency", "Min-Latency", "Avg-Latency" }; > We probably want these headers translated, please use the existing i18n mec Done Line 36: Line 37: public GlusterVolumeProfilePdfExportCommand(GlusterVolumeCreatePdfParameters params) { Line 38: super(params); Line 39: } Line 60: String userId = getParameters().getUserId(); Line 61: GlusterVolumeProfileInfo profileInfo = getParameters().getProfileInfo(); Line 62: String filePath = getParameters().getFilePath(); Line 63: Date today = new Date(); Line 64: if(filePath == null || filePath.isEmpty()) { > Same as the other file please format the file according to our formatting r Done Line 65: filePath = "/home/ababu/" + getGlusterVolumeDao().getById(profileInfo.getVolumeId()).getName() + "-" + exportData.toString()+ "-" + today.getTime() + ".pdf"; Line 66: } Line 67: try { Line 68: Document document = new Document(); http://gerrit.ovirt.org/#/c/28000/8/backend/manager/modules/common/pom.xml File backend/manager/modules/common/pom.xml: Line 23: <groupId>${engine.groupId}</groupId> Line 24: <artifactId>compat</artifactId> Line 25: <version>${engine.version}</version> Line 26: </dependency> Line 27: > please remove this white space. Done Line 28: <dependency> Line 29: <groupId>com.itextpdf</groupId> Line 30: <artifactId>itextpdf</artifactId> Line 31: <version>5.5.1</version> -- To view, visit http://gerrit.ovirt.org/28000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I208a77456487a5f735948d6cf9fec54f004b6e89 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
