Martin Peřina has posted comments on this change. Change subject: core: Adding saveOrUpdate to DbUserDao ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28429/3/packaging/dbscripts/user_sp.sql File packaging/dbscripts/user_sp.sql: Line 93: AS $procedure$ Line 94: BEGIN Line 95: PERFORM UpdateUserImpl(v_department, v_domain, v_email, v_groups, v_name, v_note, v_role, v_active, v_surname, v_user_id, v_username, v_group_ids, v_external_id, v_namespace); Line 96: UPDATE users SET Line 97: last_admin_check_status = v_last_admin_check_status Wouldn't it better to have UpdateUserImpl with all params including last_admin_check_status and here call it with NULL parameter? Instead of 2 update calls? Line 98: WHERE user_id = v_user_id; Line 99: END; $procedure$ Line 100: LANGUAGE plpgsql; Line 101: -- To view, visit http://gerrit.ovirt.org/28429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b6add7cbbe0a3055b6eb11ebf67cc77fec4bf53 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
