Oved Ourfali has posted comments on this change. Change subject: engine : Add quartz to handle AsycCommands ......................................................................
Patch Set 13: Code-Review+1 (1 comment) Looks good, but have one comment regarding the command hierarchy. http://gerrit.ovirt.org/#/c/28160/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 56: CommandCallBack callBack = cmdCallBackMap.get(cmdId); Line 57: CommandStatus status = coco.getCommandStatus(cmdId); Line 58: switch(status) { Line 59: case FAILED: Line 60: callBack.onFailed(cmdId, getChildCommandIds(cmdId)); perhaps we should be able to get the hierarchy from the coco? then, inside the onXXXX impl we can just do coco.getChildCommandIds(cmdId). Line 61: break; Line 62: case SUCCEEDED: Line 63: callBack.onSucceeded(cmdId, getChildCommandIds(cmdId)); Line 64: break; -- To view, visit http://gerrit.ovirt.org/28160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b1e5945884aec412ba412e39266129004d7218 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
