Alon Bar-Lev has posted comments on this change. Change subject: core: Configure fence_kdump during host deploy ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28386/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java: Line 573: _messages.post( Line 574: InstallerMessages.Severity.WARNING, Line 575: "Kdump detection is not supported by host!" Line 576: ); Line 577: } please move this conditional to the next when you try to enable, in this only store the supported flag. Line 578: return true; Line 579: }}, Line 580: new Callable<Boolean>() { public Boolean call() throws Exception { Line 581: _parser.cliEnvironmentSet( Line 576: ); Line 577: } Line 578: return true; Line 579: }}, Line 580: new Callable<Boolean>() { public Boolean call() throws Exception { so here you can either enable/disable/warn whatever. Line 581: _parser.cliEnvironmentSet( Line 582: KdumpEnv.ENABLE, Line 583: _vds.isPmKdumpDetection() && fenceKdumpSupported Line 584: ); -- To view, visit http://gerrit.ovirt.org/28386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc12188588a6a35b8f03d26a9ee5ea55898943df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
