Sahina Bose has posted comments on this change. Change subject: engine:fail stop volume if remove brick is running ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28472/1//COMMIT_MSG Commit Message: Line 8: Line 9: 'stop' gluster volume is not allowed if there is a remove brick operation Line 10: is running on that volume Line 11: Line 12: With multiple paragraphs if necessary. remove the above line Line 13: Line 14: Change-Id: Ic7f227b086e78374b385ebd2f4d8f8591825c7fe Line 15: Bug-Url: https://bugzilla.redhat.com/1032020 http://gerrit.ovirt.org/#/c/28472/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 2876: Line 2877: @DefaultStringValue("Cannot ${action} ${type}. Rebalance is running on the volume ${volumeName} in cluster ${vdsGroup}.") Line 2878: String ACTION_TYPE_FAILED_GLUSTER_VOLUME_CANNOT_STOP_REBALANCE_IN_PROGRESS(); Line 2879: Line 2880: @DefaultStringValue("Cannot ${action} ${type}. Remove brick operation is already running on the volume ${volumeName} in cluster ${vdsGroup}.") You can remove the "already" from message? Same goes for all messages Line 2881: String ACTION_TYPE_FAILED_GLUSTER_VOLUME_CANNOT_STOP_REMOVE_BRICK_IN_PROGRESS(); Line 2882: Line 2883: @DefaultStringValue("Cannot ${action} ${type}. The Network Interface ${IfaceName} has an invalid MAC address ${MacAddress}. MAC address must be in format \"HH:HH:HH:HH:HH:HH\" where H is a hexadecimal character (either a digit or A-F, case is insignificant).") Line 2884: String ACTION_TYPE_FAILED_NETWORK_INTERFACE_MAC_INVALID(); -- To view, visit http://gerrit.ovirt.org/28472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7f227b086e78374b385ebd2f4d8f8591825c7fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Karnan t c <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
