Martin Betak has posted comments on this change. Change subject: backend: Add cold VM reboot support ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27012/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RebootVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RebootVmCommand.java: Line 37: if (isColdRebootRequired() && FeatureSupported.powerDownOptions(getVds().getVdsGroupCompatibilityVersion())) { Line 38: log.infoFormat("VM {0} configuration has changed. Destroying and recreating with new configuration.", getVm().getName()); Line 39: TransactionSupport.executeInNewTransaction(new TransactionMethod<Void>() { Line 40: @Override Line 41: public Void runInTransaction() { > not sure transaction is needed, but if you update vm dynamic data, Done Line 42: setRebootWithReconfigurationFlag(); Line 43: getCompensationContext().stateChanged(); Line 44: return null; Line 45: } -- To view, visit http://gerrit.ovirt.org/27012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ed08f6a6ce6dfc2257da1a7cd41141d05aff039 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
