Allon Mureinik has posted comments on this change. Change subject: core: decouple recovery and reconstruct master domain ......................................................................
Patch Set 1: (1 comment) You should probably also break the heirarchy in RecoveryStoragePoolParameters extends ReconstructMasterParameters. (or just remove those two stupid classes altogether and use a single "StoragePoolAndDomainIdParameters" class http://gerrit.ovirt.org/#/c/28443/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java: Line 50: } Line 51: Line 52: @Override Line 53: protected boolean canDoAction() { Line 54: boolean returnValue = checkStoragePool(); // FIXME: check ReconstructMasterDomain canDoAction? Definately should have something of the sort. Perhaps worthwhile extracting to a helper? Line 55: Line 56: if (returnValue) { Line 57: if (getStoragePool().getStatus() == StoragePoolStatus.Uninitialized) { Line 58: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_STATUS_ILLEGAL); -- To view, visit http://gerrit.ovirt.org/28443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c066b9ff4bebce899492fcc8b54bd6a2723b453 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
