Ravi Nori has uploaded a new change for review. Change subject: engine : Collapse all Async Command Callbacks ......................................................................
engine : Collapse all Async Command Callbacks Collapse methods in Poller and EndActionCallBack into AsyncCommandCallBack interface. Change-Id: I4a81f54a2a6eb989948956a73ec0e0919b8422c4 Bug-Url: https://bugzilla.redhat.com/1083769 Signed-off-by: Ravi Nori <[email protected]> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncCommandCallBack.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCoordinator.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/EndActionCallBack.java 3 files changed, 5 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/28528/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/Poller.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncCommandCallBack.java similarity index 65% rename from backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/Poller.java rename to backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncCommandCallBack.java index 9e6e73c..3793c69 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/Poller.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncCommandCallBack.java @@ -3,13 +3,16 @@ import java.util.ArrayList; import java.util.Map; +import org.ovirt.engine.core.bll.job.ExecutionContext; +import org.ovirt.engine.core.common.action.VdcReturnValueBase; import org.ovirt.engine.core.common.asynctasks.AsyncTaskCreationInfo; import org.ovirt.engine.core.common.businessentities.AsyncTaskStatus; import org.ovirt.engine.core.compat.Guid; -public interface Poller { +public interface AsyncCommandCallBack { Map<Guid, AsyncTaskStatus> getAllTasksStatuses(Guid storagePoolID); ArrayList<AsyncTaskCreationInfo> getAllTasksInfo(Guid storagePoolID); + VdcReturnValueBase endAction(SPMTask task, ExecutionContext context); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCoordinator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCoordinator.java index 8c1741f..4c5052c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCoordinator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCoordinator.java @@ -1,4 +1,4 @@ package org.ovirt.engine.core.bll.tasks.interfaces; -public abstract class CommandCoordinator implements EndActionCallBack, TaskHelper, Poller, CommandCRUDOperations, AsyncTaskCRUDOperations { +public abstract class CommandCoordinator implements TaskHelper, AsyncCommandCallBack, CommandCRUDOperations, AsyncTaskCRUDOperations { } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/EndActionCallBack.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/EndActionCallBack.java deleted file mode 100644 index 520142c..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/EndActionCallBack.java +++ /dev/null @@ -1,8 +0,0 @@ -package org.ovirt.engine.core.bll.tasks.interfaces; - -import org.ovirt.engine.core.bll.job.ExecutionContext; -import org.ovirt.engine.core.common.action.VdcReturnValueBase; - -public interface EndActionCallBack { - public VdcReturnValueBase endAction(SPMTask task, ExecutionContext context); -} -- To view, visit http://gerrit.ovirt.org/28528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4a81f54a2a6eb989948956a73ec0e0919b8422c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
