Vojtech Szocs has posted comments on this change. Change subject: webadmin: Remove dynamic query from Configure Local Storage ......................................................................
Patch Set 3: I agree with Gilad that we should improve search query performance regardless of its usage. For this patch, I think it depends on whether it's more logical (does it make more sense) to request single cluster by name vs. request multiple clusters by name within AddClusterRM class. Since it's doing Linq.firstOrDefault on List<VDSGroup> - it assumes there can be (at most) one cluster with given name, so I'm not strictly against using GetVdsGroupByName in this case. -- To view, visit http://gerrit.ovirt.org/26545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I345d9df45dc743d6223897d839e7eb72996ad037 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
