Vojtech Szocs has posted comments on this change. Change subject: userportal: extended event sub tab loading ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/28035/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java: Line 651: iscsiStorageModel.getPropertyChangedEvent().addListener(progressEventHandler); Line 652: iscsiStorageModel.setIsGrouppedByTarget(true); Line 653: iscsiStorageModel.setIgnoreGrayedOut(true); Line 654: Line 655: iscsiStorageView = new IscsiStorageView(false, 107, 201, 240, 275, 135, 55, -62); Hm, I know it's not related to this patch, but in case of IscsiStorageView, following would be far more readable: new IscsiStorageView(false) .withTreeCollapsedHeight(107) .withTreeExpandedHeight(201) ... Line 656: iscsiStorageView.edit(iscsiStorageModel); Line 657: Line 658: // Create FcpStorageModel Line 659: fcpStorageModel = new FcpStorageModel(); -- To view, visit http://gerrit.ovirt.org/28035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81495d93c0fb9a7989ff2147d6bfcbd8d769d6ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
