Simone Tiraboschi has posted comments on this change. Change subject: Making engine configuration optional during engine-setup ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/28413/9/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py: Line 53: ), Line 54: after=( Line 55: osetupcons.Stages.DIALOG_TITLES_S_PRODUCT_OPTIONS, Line 56: ), Line 57: priority=plugin.Stages.PRIORITY_HIGH, > Maybe it's enough to keep between DIALOG_TITLES_S_PRODUCT_OPTIONS and DIALO It's also on PRIORITY_HIGH cause, if they are present, between osetupcons.Stages.DIALOG_TITLES_S_PRODUCT_OPTIONS and DIALOG_TITLES_S_PRODUCT_OPTIONS we have similar question for other options (DWH and reports) but I wan't to ask this before them. Line 58: ) Line 59: def _customization(self): Line 60: if self.environment[oenginecons.CoreEnv.ENABLE] is None: Line 61: self.environment[ -- To view, visit http://gerrit.ovirt.org/28413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a7fbc9d2abc141bed49eff20549289cba4a4a61 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
