Yair Zaslavsky has posted comments on this change. Change subject: core: remove uneeded logging from StorageHelperDirector ......................................................................
Patch Set 4: Looks good to me, but someone else must approve Looks good. Maybe we can extract the boolean condition of type != UNKNOWN && type != ALL to a boolean method, but this is a minor suggestion from my side. -- To view, visit http://gerrit.ovirt.org/5451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd95ba8f9c3c3ad80b8cfda70fd62d2bdf4b712e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
