Michael Pasternak has posted comments on this change.
Change subject: restapi: filtering the api according to ApplicationMode
......................................................................
Patch Set 1: (9 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
Line 93: ApplicationMode appMode =
getCurrent().get(ApplicationMode.class);
you using /getCurrent().get(ApplicationMode.class);/ several times in different
methods so makes sense adding it as cls-var and initializing it in .ctr
Line 148: private API getApi() {
i'd prefer having getGlusterApi() and calling it accordingly
Line 348: private API addSummary(API api) {
i'd prefer having addGlusterSummary(API api) and calling it accordingly.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java
Line 63: private Clusters mapCollection(List<VDSGroup> entities) {
i'd prefer adding mapVirtOnlyCollection() and calling it accordingly
Line 68: collection.getClusters().add(addLinks(map(entity),
"glusterVolumes"));
add "glusterVolumes" to final static var.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
Line 94: private Hosts mapCollection(List<VDS> entities) {
i'd prefer adding mapGlusterCollection() and calling it accordingly.
Line 99:
collection.getHosts().add(addLinks(populate(map(entity), entity), "storage"));
add "storage" to final static var
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
Line 164
why did you remove it ^ ?
Line 241: }
this is not ok, see what causing TrailingSlash,
(having TrailingSlash will break backward compatibility)
--
To view, visit http://gerrit.ovirt.org/5353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cf9bebe85ebc3e321006bc6e45c8ba08bfca6dd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
