Allon Mureinik has posted comments on this change. Change subject: engine: Improve iSCSI Bond CDA validation ......................................................................
Patch Set 1: Verified-1 Code-Review+2 (1 comment) +2 on the code, please remove the TWS, rebase, verify and merge. http://gerrit.ovirt.org/#/c/28605/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3112: String ACTION_TYPE_FAILED_IDE_INTERFACE_DOES_NOT_SUPPORT_READ_ONLY_ATTR(); Line 3113: Line 3114: @DefaultStringValue("Cannot ${action} ${type}. A VirtIO-SCSI LUN disk can't be read-only.") Line 3115: String ACTION_TYPE_FAILED_VIRT_IO_SCSI_INTERFACE_FOR_LUN_DISKS_DOES_NOT_SUPPORT_READ_ONLY_ATTR(); Line 3116: Please remove the TWS Line 3117: @DefaultStringValue("Cannot ${action} ${type}. Custom serial number must be non-empty when \"Custom\" serial number policy is specified.") Line 3118: String ACTION_TYPE_FAILED_INVALID_SERIAL_NUMBER(); Line 3119: Line 3120: @DefaultStringValue("Cannot ${action} ${type}. The following storage connections ${connectionIds} cannot be added to the specified iSCSI bond.\n" + -- To view, visit http://gerrit.ovirt.org/28605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d0ac7e6af6cb87b500740d679af2f13e63dbeb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
