Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Making engine configuration optional at engine-setup ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/28413/13/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/pgpass.py File packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/pgpass.py: Line 62: stage=plugin.Stages.STAGE_MISC, Line 63: name=oengcommcons.Stages.DB_CREDENTIALS_AVAILABLE_LATE, Line 64: condition=lambda self: self.environment[ Line 65: oengcommcons.EngineDBEnv.PASSWORD Line 66: ] is not None, > if if understood correctly Didi's work it's bit different. if this is what is done it is wrong. I sent you guys again the email I sent before. each component should ask for his own databases and the databases it consumes, as when the database that are consumed are being asked the environment is already set, it won't be asked again. Line 67: ) Line 68: def _misc(self): Line 69: database.OvirtUtils( Line 70: plugin=self, -- To view, visit http://gerrit.ovirt.org/28413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a7fbc9d2abc141bed49eff20549289cba4a4a61 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
