Gustavo Frederico Temple Pedrosa has posted comments on this change. Change subject: core, engine: Disable Migrate On Error on ppc64 clusters ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/21644/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsCpuFlagsOrClusterChangedCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsCpuFlagsOrClusterChangedCommand.java: Line 142: protected ArchitectureType getArchitecture(VDSGroup group) { Line 143: if (StringUtils.isNotEmpty(group.getcpu_name())) { Line 144: return CpuFlagsManagerHandler.getArchitectureByCpuName(group.getcpu_name(), Line 145: group.getcompatibility_version()); Line 146: } else if (group.getArchitecture() == null) { > this can't be null as at line 88 sets it to undefinded already... Done Line 147: return ArchitectureType.undefined; Line 148: } Line 149: Line 150: return group.getArchitecture(); -- To view, visit http://gerrit.ovirt.org/21644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556ef1ce4896ddeb39b93a93520fd0535b4fa28c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
