Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: engine-cleanup split
......................................................................


Patch Set 14: Code-Review+1

> Ok, but in another patch I think. We should think about group of groups or to 
> add another property to describe the product option of the group.

I agree, changing the way groups work or changing groups name can and should be 
addressed in a separate patch. Noted is as a todo in the code to be sure to 
remember to work on it. Alon, other than that, do you have more comments? Or 
can we merge this?

-- 
To view, visit http://gerrit.ovirt.org/28579
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26017770262e313ad38ddfa96baeaea144c86e5f
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to