Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Allow dwh on separate host ......................................................................
Patch Set 10: (4 comments) just answered my question... how will it look at dwh. looks good! some comments that repeat mostly what I commented at engine side. thanks! http://gerrit.ovirt.org/#/c/27516/10/packaging/setup/ovirt_engine_setup/dwh/constants.py File packaging/setup/ovirt_engine_setup/dwh/constants.py: Line 74 Line 75 Line 76 Line 77 Line 78 so we can drop the EgnineDefaults Line 101: 'secured': EngineDefaults.DEFAULT_DB_SECURED, Line 102: 'hostValidation': EngineDefaults.DEFAULT_DB_SECURED_HOST_VALIDATION, Line 103: 'user': EngineDefaults.DEFAULT_DB_USER, Line 104: 'password': EngineDefaults.DEFAULT_DB_PASSWORD, Line 105: 'database': EngineDefaults.DEFAULT_DB_DATABASE, I do not think we need defaults as consumer, especially not for database, host. so the defaults should be able to be set with None and at None you set the trivial defaults (no ssl, no host validation...) all in database.py Line 106: } Line 107: Line 108: Line 109: @util.export Line 114: DEFAULT_DB_DATABASE = 'ovirt_engine_history' Line 115: DEFAULT_DB_USER = 'ovirt_engine_history' Line 116: DEFAULT_DB_PASSWORD = '' Line 117: DEFAULT_DB_SECURED = False Line 118: DEFAULT_DB_SECURED_HOST_VALIDATION = False as you have the defaults above, no need for this one either. Line 119: Line 120: Line 121: @util.export Line 122: @util.codegen http://gerrit.ovirt.org/#/c/27516/10/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py: Line 108 Line 109 Line 110 Line 111 Line 112 it would be nicer as I wrote in the other patch to be between: DIALOG_TITLES_S_OWNERS DIALOG_TITLES_E_OWNERS or: DIALOG_TITLES_S_CONSUMERS DIALOG_TITLES_E_CONSUMERS -- To view, visit http://gerrit.ovirt.org/27516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06fc960481af258b3954a8968be3439393d3ebdb Gerrit-PatchSet: 10 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
