Dan Kenigsberg has posted comments on this change. Change subject: webadmin: Fix getFriendlyVersion ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) you can continue this translation nonsense as long as you like... .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Extensions.java Line 76: public static Version GetFriendlyVersion(Version source) I find it unfriendly to take vdsm's version and apply a funny conversion function so that it is hidden from the user. -- To view, visit http://gerrit.ovirt.org/5489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e55c73d4b7747d8af8dcda5e112694aeea3030 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
